1
0
mirror of https://github.com/gsi-upm/sitc synced 2024-11-24 15:32:29 +00:00

Minor change in contribution instructions

This commit is contained in:
J. Fernando Sánchez 2019-02-04 10:53:54 +01:00
parent bf295c3d7e
commit 8913c5ecde

View File

@ -1,10 +1,11 @@
# Contributing # Contributing
When contributing to this repository, please consider the scope of your contribution. When contributing to this repository, please consider the scope of your contribution.
For major corrections (other than typos and minor code changes), please first discuss the change you wish to make via issue, For major corrections (other than typos and minor code changes), please first discuss the change you wish to make via a GitHub issue,
email, or any other method with the owners of this repository before making a change. email, or any other method with the owners of this repository before working on your change.
If you fail to do so, your contribution may be rejected.
Please note we have a code of conduct, please follow it in all your interactions with the project. Also note that we have a code of conduct, please follow it in all your interactions with the project.
## Pull Request Process ## Pull Request Process
@ -13,9 +14,9 @@ Please note we have a code of conduct, please follow it in all your interactions
2. If you are adding code, ensure the changed notebooks can be run in a fresh environment. Include instructions to download 2. If you are adding code, ensure the changed notebooks can be run in a fresh environment. Include instructions to download
any additional dependencies. any additional dependencies.
3. Ensure any spurious changes are removed, such as compilation files (`pyc`) or metadata changes in a notebook. 3. Ensure any spurious changes are removed, such as compilation files (`pyc`) or metadata changes in a notebook.
4. A member of the GSI-UPM group will review your request. The reviewer may choose to accept the request, ask for further changes, 4. Submit your pull request on GitHub.
or reject the request. 5. A member of the GSI-UPM group will review your request.
6. The reviewer may ask for further changes before merging the contribution. Please, follow the reviewer's instructions before resubmitting.
## Code of Conduct ## Code of Conduct