Fixed version.sh

.gitignore

@@ -6,5 +6,3 @@ build
 README.html
 __pycache__
 VERSION
-Dockerfile-*
-Dockerfile

.gitlab-ci.yml

@@ -1,4 +1,4 @@
-image: gsiupm/dockermake:latest
+image: docker:latest
 
 
 # When using dind, it's wise to use the overlayfs driver for
@@ -6,60 +6,75 @@ image: gsiupm/dockermake:latest
 variables:
   DOCKER_DRIVER: overlay
   DOCKERFILE: Dockerfile
-  IMAGENAME: $CI_REGISTRY_IMAGE
+
+before_script:
+  - sh version.sh > senpy/VERSION
 
 stages:
   - test
-  - push
-  - clean
+  - images
+  - release
 
 .test: &test_definition
+  variables:
+    PIP_CACHE_DIR: "$CI_PROJECT_DIR/pip-cache"
+  cache:
+    paths:
+      - .eggs/
+      - "$CI_PROJECT_DIR/pip-cache"
+      - .venv
+    key: "$CI_PROJECT_NAME"
   stage: test
   script:
-    - make -e test-$PYTHON_VERSION
+    - pip install --use-wheel -U pip setuptools virtualenv
+    - virtualenv .venv/$PYTHON_VERSION
+    - source .venv/$PYTHON_VERSION/bin/activate
+    - pip install --use-wheel -r requirements.txt
+    - pip install --use-wheel -r test-requirements.txt
+    - py.test --cov=senpy --cov-report term-missing
+    - python 
     
 test-3.5:
   <<: *test_definition
-  variables:
-    PYTHON_VERSION: "3.5"
+  image: "python:3.5"
 
 test-2.7:
   <<: *test_definition
-  variables:
-    PYTHON_VERSION: "2.7"
+  image: "python:2.7"
 
 
 .image: &image_definition
-  stage: push
+  variables:
+    PYTHON_VERSION: "3.5"
   before_script:
     - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN $CI_REGISTRY
   script:
-    - make -e push-$PYTHON_VERSION
+    - docker build -f Dockerfile-3.5 . -t $CI_REGISTRY_IMAGE:$CI_BUILD_REF_SLUG-$PYTHON_VERSION
+    - docker push $CI_REGISTRY_IMAGE:$CI_BUILD_REF_SLUG-$PYTHON_VERSION
+  stage: images
   only:
     - tags
     - triggers
 
-push-3.5:
+image-3.5:
   <<: *image_definition
   variables:
     PYTHON_VERSION: "3.5"
 
-push-2.7:
+image-2.7:
   <<: *image_definition
   variables:
     PYTHON_VERSION: "2.7"
 
-push-latest:
-  <<: *image_definition
-  variables:
-    PYTHON_VERSION: latest
+image-latest:
+  stage: release
+  before_script:
+    - docker login -u gitlab-ci-token -p $CI_BUILD_TOKEN $CI_REGISTRY
+  script:
+    - docker build -f Dockerfile . -t $CI_REGISTRY_IMAGE
+    - docker tag $CI_REGISTRY_IMAGE $CI_REGISTRY_IMAGE:$CI_BUILD_REF_SLUG
+    - docker push $CI_REGISTRY_IMAGE
+    - docker push $CI_REGISTRY_IMAGE:$CI_BUILD_REF_SLUG
   only:
     - master
-    - triggers
-
-clean :
-  stage: clean
-  script:
-    - make -e clean
-  only:
-    - master
+    - triggers

.pre-commit-config.yaml

@@ -1,5 +0,0 @@
--   repo: git://github.com/pre-commit/pre-commit-hooks
-    sha: e626cd57090d8df0be21e4df0f4e55cc3511d6ab
-    hooks:
-    -   id: flake8
-    -   id: check-json

.travis.yml

@@ -1,13 +1,8 @@
-sudo: required
-
-services:
-  - docker
-
 language: python
-
-env:
-  - PYV=2.7
-  - PYV=3.4
-  - PYV=3.5
+python:
+  - "2.7"
+  - "3.4"
+  - "3.5"
+install: "pip install -r requirements.txt"
 # run nosetests - Tests
-script: make test-$PYV
+script: nosetests

Dockerfile

@@ -0,0 +1 @@
+Dockerfile-3.5

Dockerfile-2.7

@@ -0,0 +1,21 @@
+from python:2.7
+
+RUN mkdir /cache/
+ENV PIP_CACHE_DIR=/cache/
+
+WORKDIR /usr/src/app
+ADD requirements.txt /usr/src/app/
+RUN pip install --use-wheel -r requirements.txt
+ADD . /usr/src/app/
+RUN pip install .
+
+
+VOLUME /data/
+
+RUN mkdir /senpy-plugins/
+
+WORKDIR /senpy-plugins/
+ONBUILD ADD . /senpy-plugins/
+ONBUILD RUN python -m senpy --only-install -f /senpy-plugins
+
+ENTRYPOINT ["python", "-m", "senpy", "-f", "/senpy-plugins/", "--host", "0.0.0.0"]

Dockerfile-3.4

@@ -0,0 +1,21 @@
+from python:3.4
+
+RUN mkdir /cache/
+ENV PIP_CACHE_DIR=/cache/
+
+WORKDIR /usr/src/app
+ADD requirements.txt /usr/src/app/
+RUN pip install --use-wheel -r requirements.txt
+ADD . /usr/src/app/
+RUN pip install .
+
+
+VOLUME /data/
+
+RUN mkdir /senpy-plugins/
+
+WORKDIR /senpy-plugins/
+ONBUILD ADD . /senpy-plugins/
+ONBUILD RUN python -m senpy --only-install -f /senpy-plugins
+
+ENTRYPOINT ["python", "-m", "senpy", "-f", "/senpy-plugins/", "--host", "0.0.0.0"]

Dockerfile-3.5

@@ -0,0 +1,21 @@
+FROM python:3.5
+
+RUN mkdir /cache/
+ENV PIP_CACHE_DIR=/cache/
+
+WORKDIR /usr/src/app
+ADD requirements.txt /usr/src/app/
+RUN pip install --use-wheel -r requirements.txt
+ADD . /usr/src/app/
+RUN pip install .
+
+
+VOLUME /data/
+
+RUN mkdir /senpy-plugins/
+
+WORKDIR /senpy-plugins/
+ONBUILD ADD . /senpy-plugins/
+ONBUILD RUN python -m senpy --only-install -f /senpy-plugins
+
+ENTRYPOINT ["python", "-m", "senpy", "-f", "/senpy-plugins/", "--host", "0.0.0.0"]

Dockerfile.deps

@@ -0,0 +1,33 @@
+from python:2.7
+
+RUN apt-get update
+RUN apt-get -y install git
+RUN mkdir -p /senpy-plugins
+
+RUN apt-get -y install python-numpy
+RUN apt-get -y install python-scipy
+RUN apt-get -y install python-sklearn
+RUN apt-get -y install python-gevent
+RUN apt-get -y install libopenblas-dev
+RUN apt-get -y install gfortran
+RUN apt-get -y install libxml2-dev libxslt1-dev python-dev
+
+#RUN pip install --upgrade pip
+
+ADD id_rsa /root/.ssh/id_rsa
+RUN chmod 700 /root/.ssh/id_rsa
+RUN echo "Host github.com\n\tStrictHostKeyChecking no\n" >> /root/.ssh/config
+
+RUN git clone https://github.com/gsi-upm/senpy /usr/src/app/
+RUN git clone git@github.com:gsi-upm/senpy-plugins-enterprise /senpy-plugins/enterprise
+RUN git clone https://github.com/gsi-upm/senpy-plugins-community /senpy-plugins/community
+
+RUN pip install /usr/src/app
+RUN pip install --no-use-wheel -r /senpy-plugins/enterprise/requirements.txt
+RUN python -m nltk.downloader stopwords
+RUN python -m nltk.downloader punkt
+RUN python -m nltk.downloader maxent_treebank_pos_tagger
+RUN python -m nltk.downloader wordnet
+
+WORKDIR /senpy-plugins
+ENTRYPOINT ["python", "-m", "senpy", "-f", ".", "--host", "0.0.0.0"]

Dockerfile.template

@@ -1,22 +1,21 @@
 from python:{{PYVERSION}}
 
-MAINTAINER J. Fernando Sánchez <jf.sanchez@upm.es>
+RUN mkdir /cache/
+ENV PIP_CACHE_DIR=/cache/
+
+WORKDIR /usr/src/app
+ADD requirements.txt /usr/src/app/
+RUN pip install --use-wheel -r requirements.txt
+ADD . /usr/src/app/
+RUN pip install .
 
-RUN mkdir /cache/ /senpy-plugins /data/
 
 VOLUME /data/
 
-ENV PIP_CACHE_DIR=/cache/
+RUN mkdir /senpy-plugins/
 
-ONBUILD COPY . /senpy-plugins/
+WORKDIR /senpy-plugins/
+ONBUILD ADD . /senpy-plugins/
 ONBUILD RUN python -m senpy --only-install -f /senpy-plugins
-ONBUILD WORKDIR /senpy-plugins/
-
-
-WORKDIR /usr/src/app
-COPY test-requirements.txt requirements.txt /usr/src/app/
-RUN pip install --use-wheel -r test-requirements.txt -r requirements.txt
-COPY . /usr/src/app/
-RUN pip install --no-deps --no-index .
 
 ENTRYPOINT ["python", "-m", "senpy", "-f", "/senpy-plugins/", "--host", "0.0.0.0"]

Makefile

@@ -1,18 +1,17 @@
-PYVERSIONS=3.5 2.7
+PYVERSIONS=3.5 3.4 2.7
 PYMAIN=$(firstword $(PYVERSIONS))
 NAME=senpy
 REPO=gsiupm
-VERSION=$(shell git describe --tags --dirty 2>/dev/null)
+VERSION=$(shell ./version.sh)
 TARNAME=$(NAME)-$(VERSION).tar.gz 
-IMAGENAME=$(REPO)/$(NAME)
-IMAGEWTAG=$(IMAGENAME):$(VERSION)
-action="test-${PYMAIN}"
+IMAGENAME=$(REPO)/$(NAME):$(VERSION)
+TEST_COMMAND=gitlab-runner exec docker --cache-dir=/tmp/gitlabrunner --docker-volumes /tmp/gitlabrunner:/tmp/gitlabrunner --env CI_PROJECT_NAME=$(NAME)
 
 all: build run
 
-.FORCE:
+FORCE:
 
-version: .FORCE
+version: FORCE
 	@echo $(VERSION) > $(NAME)/VERSION
 	@echo $(VERSION)
 
@@ -20,7 +19,7 @@ yapf:
 	yapf -i -r senpy
 	yapf -i -r tests
 
-init:
+dev:
 	pip install --user pre-commit
 	pre-commit install
 
@@ -35,27 +34,26 @@ quick_build: $(addprefix build-, $(PYMAIN))
 
 build: $(addprefix build-, $(PYVERSIONS))
 
-build-%: version Dockerfile-%
-	docker build -t '$(IMAGEWTAG)-python$*' -f Dockerfile-$* .;
+build-%: Dockerfile-%
+	docker build -t '$(IMAGENAME)-python$*' -f Dockerfile-$* .;
 
 quick_test: $(addprefix test-,$(PYMAIN))
 
-dev-%:
-	@docker start $(NAME)-dev$* || (\
+test: $(addprefix test-,$(PYVERSIONS))
+
+debug-%:
+	@docker start $(NAME)-debug || (\
 		$(MAKE) build-$*; \
-		docker run -d -w /usr/src/app/ -v $$PWD:/usr/src/app --entrypoint=/bin/bash -ti --name $(NAME)-dev$* '$(IMAGEWTAG)-python$*'; \
+		docker run -d -w /usr/src/app/ -v $$PWD:/usr/src/app --entrypoint=/bin/bash -p 5000:5000 -ti --name $(NAME)-debug '$(IMAGENAME)-python$*'; \
+		docker exec -ti $(NAME)-debug pip install -r test-requirements.txt; \
 	)\
 
-	docker exec -ti $(NAME)-dev$* bash
+	docker attach $(NAME)-debug
 
-dev: dev-$(PYMAIN)
+debug: debug-$(PYMAIN)
 
-test-all: $(addprefix test-,$(PYVERSIONS))
-
-test-%: build-%
-	docker run --rm --entrypoint /usr/local/bin/python -w /usr/src/app $(IMAGEWTAG)-python$*  setup.py test
-
-test: test-$(PYMAIN)
+test-%:
+	$(TEST_COMMAND) test-$*
 
 dist/$(TARNAME):
 	docker run --rm -ti -v $$PWD:/usr/src/app/ -w /usr/src/app/ python:$(PYMAIN) python setup.py sdist;
@@ -67,10 +65,19 @@ pip_test-%: sdist
 
 pip_test: $(addprefix pip_test-,$(PYVERSIONS))
 
+upload-%: test-%
+	docker push '$(IMAGENAME)-python$*'
+
+upload: test $(addprefix upload-,$(PYVERSIONS))
+	docker tag '$(IMAGENAME)-python$(PYMAIN)' '$(IMAGENAME)'
+	docker tag '$(IMAGENAME)-python$(PYMAIN)' '$(REPO)/$(NAME)'
+	docker push '$(IMAGENAME)'
+	docker push '$(REPO)/$(NAME)'
+
 clean:
 	@docker ps -a | awk '/$(REPO)\/$(NAME)/{ split($$2, vers, "-"); if(vers[0] != "${VERSION}"){ print $$1;}}' | xargs docker rm -v 2>/dev/null|| true
 	@docker images | awk '/$(REPO)\/$(NAME)/{ split($$2, vers, "-"); if(vers[0] != "${VERSION}"){ print $$1":"$$2;}}' | xargs docker rmi 2>/dev/null|| true
-	@docker rmi $(NAME)-dev 2>/dev/null || true
+	@docker rmi $(NAME)-debug 2>/dev/null || true
 
 
 git_commit:
@@ -79,7 +86,7 @@ git_commit:
 git_tag:
 	git tag ${VERSION}
 
-git_push:
+upload_git:
 	git push --tags origin master
 
 pip_upload:
@@ -88,20 +95,8 @@ pip_upload:
 pip_test: $(addprefix pip_test-,$(PYVERSIONS))
 
 run-%: build-%
-	docker run --rm -p 5000:5000 -ti '$(IMAGEWTAG)-python$(PYMAIN)' --default-plugins
+	docker run --rm -p 5000:5000 -ti '$(IMAGENAME)-python$(PYMAIN)' --default-plugins
 
 run: run-$(PYMAIN)
 
-push-latest: build-$(PYMAIN)
-	docker tag '$(IMAGEWTAG)-python$(PYMAIN)' '$(IMAGEWTAG)'
-	docker tag '$(IMAGEWTAG)-python$(PYMAIN)' '$(IMAGENAME)'
-	docker push '$(IMAGENAME)'
-	docker push '$(IMAGEWTAG)'
-
-push-%: build-%
-	docker push $(IMAGENAME):$(VERSION)-python$*
-
-ci:
-	gitlab-runner exec docker --docker-volumes /var/run/docker.sock:/var/run/docker.sock --env CI_PROJECT_NAME=$(NAME) ${action}
-
-.PHONY: test test-% test-all build-% build test pip_test run yapf push-main push-% dev ci version .FORCE
+.PHONY: test test-% build-% build test pip_test run yapf dev

README.rst

@@ -38,9 +38,9 @@ If you want to install senpy globally, use sudo instead of the ``--user`` flag.
 
 Docker Image
 ************
-Build the image or use the pre-built one: ``docker run -ti -p 5000:5000 gsiupm/senpy --default-plugins``.
+Build the image or use the pre-built one: ``docker run -ti -p 5000:5000 gsiupm/senpy --host 0.0.0.0 --default-plugins``.
 
-To add custom plugins, add a volume and tell senpy where to find the plugins: ``docker run -ti -p 5000:5000 -v <PATH OF PLUGINS>:/plugins gsiupm/senpy --default-plugins -f /plugins``
+To add custom plugins, add a volume and tell senpy where to find the plugins: ``docker run -ti -p 5000:5000 -v <PATH OF PLUGINS>:/plugins gsiupm/senpy --host 0.0.0.0 --default-plugins -f /plugins``
 
 Usage
 -----

senpy/extensions.py

@@ -13,11 +13,10 @@ from .api import API_PARAMS, NIF_PARAMS, parse_params
 from threading import Thread
 
 import os
-import copy
 import fnmatch
 import inspect
 import sys
-import importlib
+import imp
 import logging
 import traceback
 import yaml
@@ -181,7 +180,7 @@ class Senpy(object):
         newentries = []
         for i in resp.entries:
             if output == "full":
-                newemotions = copy.deepcopy(i.emotions)
+                newemotions = i.emotions.copy()
             else:
                 newemotions = []
             for j in i.emotions:
@@ -285,11 +284,11 @@ class Senpy(object):
 
     @classmethod
     def validate_info(cls, info):
-        return all(x in info for x in ('name', 'module', 'description', 'version'))
+        return all(x in info for x in ('name', 'module', 'version'))
 
     def install_deps(self):
         for i in self.plugins.values():
-            self._install_deps(i)
+            self._install_deps(i._info)
 
     @classmethod
     def _install_deps(cls, info=None):
@@ -303,13 +302,6 @@ class Senpy(object):
             logger.info('Installing requirements: ' + str(requirements))
             pip.main(pip_args)
 
-    @classmethod
-    def _load_module(cls, name, root):
-        sys.path.append(root)
-        tmp = importlib.import_module(name)
-        sys.path.remove(root)
-        return tmp
-
     @classmethod
     def _load_plugin_from_info(cls, info, root):
         if not cls.validate_info(info):
@@ -317,10 +309,11 @@ class Senpy(object):
             return None, None
         module = info["module"]
         name = info["name"]
-
+        sys.path.append(root)
+        (fp, pathname, desc) = imp.find_module(module, [root, ])
         cls._install_deps(info)
-        tmp = cls._load_module(module, root)
-
+        tmp = imp.load_module(module, fp, pathname, desc)
+        sys.path.remove(root)
         candidate = None
         for _, obj in inspect.getmembers(tmp):
             if inspect.isclass(obj) and inspect.getmodule(obj) == tmp:

senpy/plugins.py

@@ -7,7 +7,7 @@ import pickle
 import logging
 import tempfile
 import copy
-from .. import models
+from . import models
 
 logger = logging.getLogger(__name__)
 

senpy/plugins/conversion/centroids.py

@@ -1,52 +0,0 @@
-from senpy.plugins import EmotionConversionPlugin
-from senpy.models import EmotionSet, Emotion, Error
-
-import logging
-logger = logging.getLogger(__name__)
-
-
-class CentroidConversion(EmotionConversionPlugin):
-
-    def _forward_conversion(self, original):
-        """Sum the VAD value of all categories found."""
-        res = Emotion()
-        for e in original.onyx__hasEmotion:
-            category = e.onyx__hasEmotionCategory
-            if category in self.centroids:
-                for dim, value in self.centroids[category].iteritems():
-                    try:
-                        res[dim] += value
-                    except Exception:
-                        res[dim] = value
-        return res
-
-    def _backwards_conversion(self, original):
-        """Find the closest category"""
-        dimensions = list(self.centroids.values())[0]
-
-        def distance(e1, e2):
-            return sum((e1[k] - e2.get(self.aliases[k], 0)) for k in dimensions)
-
-        emotion = ''
-        mindistance = 10000000000000000000000.0
-        for state in self.centroids:
-            d = distance(self.centroids[state], original)
-            if d < mindistance:
-                mindistance = d
-                emotion = state
-        result = Emotion(onyx__hasEmotionCategory=emotion)
-        return result
-
-    def convert(self, emotionSet, fromModel, toModel, params):
-
-        cf, ct = self.centroids_direction
-        logger.debug('{}\n{}\n{}\n{}'.format(emotionSet, fromModel, toModel, params))
-        e = EmotionSet()
-        if fromModel == cf:
-            e.onyx__hasEmotion.append(self._forward_conversion(emotionSet))
-        elif fromModel == ct:
-            for i in emotionSet.onyx__hasEmotion:
-                e.onyx__hasEmotion.append(self._backwards_conversion(i))
-        else:
-            raise Error('EMOTION MODEL NOT KNOWN')
-        yield e

senpy/plugins/conversion/emotion/ekman2vad.py

@@ -0,0 +1,56 @@
+from senpy.plugins import EmotionConversionPlugin
+from senpy.models import EmotionSet, Emotion, Error
+
+import logging
+logger = logging.getLogger(__name__)
+
+import math
+
+
+class WNA2VAD(EmotionConversionPlugin):
+
+    def _ekman_to_vad(self, ekmanSet):
+        potency = 0
+        arousal = 0
+        dominance = 0
+        for e in ekmanSet.onyx__hasEmotion:
+            category = e.onyx__hasEmotionCategory
+            centroid = self.centroids[category]
+            potency += centroid['V']
+            arousal += centroid['A']
+            dominance += centroid['D']
+        e = Emotion({'emoml:potency': potency,
+                     'emoml:arousal': arousal,
+                     'emoml:dominance': dominance})
+        return e
+
+    def _vad_to_ekman(self, VADEmotion):
+        V = VADEmotion['emoml:valence']
+        A = VADEmotion['emoml:potency']
+        D = VADEmotion['emoml:dominance']
+        emotion = ''
+        value = 10000000000000000000000.0
+        for state in self.centroids:
+            valence = V - self.centroids[state]['V']
+            arousal = A - self.centroids[state]['A']
+            dominance = D - self.centroids[state]['D']
+            new_value = math.sqrt((valence**2) +
+                                  (arousal**2) +
+                                  (dominance**2))
+            if new_value < value:
+                value = new_value
+                emotion = state
+        result = Emotion(onyx__hasEmotionCategory=emotion)
+        return result
+
+    def convert(self, emotionSet, fromModel, toModel, params):
+        logger.debug('{}\n{}\n{}\n{}'.format(emotionSet, fromModel, toModel, params))
+        e = EmotionSet()
+        if fromModel == 'emoml:big6':
+            e.onyx__hasEmotion.append(self._ekman_to_vad(emotionSet))
+        elif fromModel == 'emoml:fsre-dimensions':
+            for i in emotionSet.onyx__hasEmotion:
+                e.onyx__hasEmotion.append(self._vad_to_ekman(e))
+        else:
+            raise Error('EMOTION MODEL NOT KNOWN')
+        yield e

senpy/plugins/conversion/emotion/ekman2vad.senpy

@@ -1,13 +1,13 @@
 ---
 name: Ekman2VAD
-module: senpy.plugins.conversion.centroids
-description: Plugin to convert emotion sets from Ekman to VAD
+module: ekman2vad
+description: Plugin to convert from Ekman to VAD
 version: 0.1
 onyx:doesConversion:
   - onyx:conversionFrom: emoml:big6
     onyx:conversionTo: emoml:fsre-dimensions
   - onyx:conversionFrom: emoml:fsre-dimensions
-    onyx:conversionTo: emoml:big6
+    onyx:conversionTo: wna:WNAModel
 centroids:
   emoml:big6anger:
     A: 6.95
@@ -29,10 +29,7 @@ centroids:
     A: 5.21
     D: 2.82
     V: 2.21
-centroids_direction:
-  - emoml:big6
-  - emoml:fsre-dimensions
 aliases:
   A: emoml:arousal
-  V: emoml:valence
+  V: emoml:potency
   D: emoml:dominance

setup.cfg

@@ -9,6 +9,4 @@ test=pytest
 ignore = E402
 max-line-length = 100
 [bdist_wheel]
-universal=1
-[tool:pytest]
-addopts = --cov=senpy --cov-report term-missing
+universal=1

test-requirements.txt

@@ -1,3 +1,3 @@
+pytest
 mock
 pytest-cov
-pytest

tests/test_api.py

@@ -1,68 +0,0 @@
-import logging
-
-logger = logging.getLogger(__name__)
-
-from unittest import TestCase
-from senpy.api import parse_params, API_PARAMS, NIF_PARAMS, WEB_PARAMS
-from senpy.models import Error
-
-
-class APITest(TestCase):
-
-    def test_api_params(self):
-        """The API should not define any required parameters without a default"""
-        parse_params({}, spec=API_PARAMS)
-
-    def test_web_params(self):
-        """The WEB should not define any required parameters without a default"""
-        parse_params({}, spec=WEB_PARAMS)
-
-    def test_basic(self):
-        a = {}
-        try:
-            parse_params(a, spec=NIF_PARAMS)
-            raise AssertionError()
-        except Error:
-            pass
-        a = {'input': 'hello'}
-        p = parse_params(a, spec=NIF_PARAMS)
-        assert 'input' in p
-        b = {'i': 'hello'}
-        p = parse_params(b, spec=NIF_PARAMS)
-        assert 'input' in p
-
-    def test_plugin(self):
-        query = {}
-        plug_params = {
-            'hello': {
-                'aliases': ['hello', 'hiya'],
-                'required': True
-            }
-        }
-        try:
-            parse_params(query, spec=plug_params)
-            raise AssertionError()
-        except Error:
-            pass
-        query['hello'] = 'world'
-        p = parse_params(query, spec=plug_params)
-        assert 'hello' in p
-        assert p['hello'] == 'world'
-        del query['hello']
-
-        query['hiya'] = 'dlrow'
-        p = parse_params(query, spec=plug_params)
-        assert 'hello' in p
-        assert 'hiya' in p
-        assert p['hello'] == 'dlrow'
-
-    def test_default(self):
-        spec = {
-            'hello': {
-                'required': True,
-                'default': 1
-            }
-        }
-        p = parse_params({}, spec=spec)
-        assert 'hello' in p
-        assert p['hello'] == 1

tests/test_extensions.py

@@ -1,6 +1,5 @@
 from __future__ import print_function
 import os
-from copy import deepcopy
 import logging
 
 try:
@@ -10,7 +9,7 @@ except ImportError:
 
 from functools import partial
 from senpy.extensions import Senpy
-from senpy.models import Error, Results, Entry, EmotionSet, Emotion
+from senpy.models import Error
 from flask import Flask
 from unittest import TestCase
 
@@ -43,7 +42,6 @@ class ExtensionsTest(TestCase):
         info = {
             'name': 'TestPip',
             'module': 'dummy',
-            'description': None,
             'requirements': ['noop'],
             'version': 0
         }
@@ -53,7 +51,6 @@ class ExtensionsTest(TestCase):
         assert module
         import noop
         dir(noop)
-        self.senpy.install_deps()
 
     def test_installing(self):
         """ Enabling a plugin """
@@ -122,42 +119,3 @@ class ExtensionsTest(TestCase):
     def test_load_default_plugins(self):
         senpy = Senpy(plugin_folder=self.dir, default_plugins=True)
         assert len(senpy.plugins) > 1
-
-    def test_convert_emotions(self):
-        self.senpy.activate_all()
-        plugin = {
-            'id': 'imaginary',
-            'onyx:usesEmotionModel': 'emoml:fsre-dimensions'
-        }
-        eSet1 = EmotionSet()
-        eSet1['onyx:hasEmotion'].append(Emotion({
-            'emoml:arousal': 1,
-            'emoml:potency': 0,
-            'emoml:valence': 0
-        }))
-        response = Results({
-            'entries': [Entry({
-                'text': 'much ado about nothing',
-                'emotions': [eSet1]
-            })]
-        })
-        params = {'emotionModel': 'emoml:big6',
-                  'conversion': 'full'}
-        r1 = deepcopy(response)
-        self.senpy.convert_emotions(r1,
-                                    plugin,
-                                    params)
-        assert len(r1.entries[0].emotions) == 2
-        params['conversion'] = 'nested'
-        r2 = deepcopy(response)
-        self.senpy.convert_emotions(r2,
-                                    plugin,
-                                    params)
-        assert len(r2.entries[0].emotions) == 1
-        assert r2.entries[0].emotions[0]['prov:wasDerivedFrom'] == eSet1
-        params['conversion'] = 'filtered'
-        r3 = deepcopy(response)
-        self.senpy.convert_emotions(r3,
-                                    plugin,
-                                    params)
-        assert len(r3.entries[0].emotions) == 1

tests/test_models.py

@@ -143,3 +143,7 @@ class ModelsTest(TestCase):
         print(t)
         g = rdflib.Graph().parse(data=t, format='turtle')
         assert len(g) == len(triples)
+
+    def test_convert_emotions(self):
+        """It should be possible to convert between different emotion models"""
+        pass

version.sh

@@ -0,0 +1,2 @@
+#!/bin/sh
+git describe --long --tags --dirty