Fixed py2 problems and other improvements

We've changed the way plugins are activated, and removed the notion of
deactivated plugins.
Now plugins activate asynchronously.
When calling a plugin, it will be activated if it wasn't, and the call will wait
for the plugin to be fully activated.

tests/plugins/sleep_plugin/sleep.senpy

@@ -4,7 +4,7 @@
     "description": "I am dummy",
     "author": "@balkian",
     "version": "0.1",
-    "timeout": 0.5,
+    "timeout": 0.05,
     "extra_params": {
         "timeout": {
             "@id": "timeout_sleep",

tests/test_api.py

@@ -66,3 +66,14 @@ class APITest(TestCase):
         p = parse_params({}, spec)
         assert 'hello' in p
         assert p['hello'] == 1
+
+    def test_call(self):
+        call = {
+            'input': "Aloha my friend",
+            'algo': "Dummy"
+        }
+        p = parse_params(call, API_PARAMS, NIF_PARAMS)
+        assert 'algorithm' in p
+        assert "Dummy" in p['algorithm']
+        assert 'input' in p
+        assert p['input'] == 'Aloha my friend'

tests/test_blueprints.py

@@ -66,7 +66,7 @@ class BlueprintsTest(TestCase):
         """
         Extra params that have a default should
         """
-        resp = self.client.get("/api/?i=My aloha mohame&algo=Dummy")
+        resp = self.client.get("/api/?i=My aloha mohame&algo=Dummy&with_parameters=true")
         self.assertCode(resp, 200)
         js = parse_resp(resp)
         logging.debug("Got response: %s", js)

tests/test_extensions.py

@@ -55,8 +55,9 @@ class ExtensionsTest(TestCase):
             'version': 0
         }
         root = os.path.join(self.dir, 'plugins', 'dummy_plugin')
-        name, module = plugins.load_plugin_from_info(info, root=root)
-        assert name == 'TestPip'
+        module = plugins.load_plugin_from_info(info, root=root)
+        plugins.install_deps(info)
+        assert module.name == 'TestPip'
         assert module
         import noop
         dir(noop)
@@ -76,9 +77,8 @@ class ExtensionsTest(TestCase):
             'requirements': ['IAmMakingThisPackageNameUpToFail'],
             'version': 0
         }
-        root = os.path.join(self.dir, 'plugins', 'dummy_plugin')
         with self.assertRaises(Error):
-            name, module = plugins.load_plugin_from_info(info, root=root)
+            plugins.install_deps(info)
 
     def test_disabling(self):
         """ Disabling a plugin """
@@ -98,12 +98,6 @@ class ExtensionsTest(TestCase):
         """ Don't analyse if there isn't any plugin installed """
         self.senpy.deactivate_all(sync=True)
         self.assertRaises(Error, partial(analyse, self.senpy, input="tupni"))
-        self.assertRaises(Error,
-                          partial(
-                              analyse,
-                              self.senpy,
-                              input="tupni",
-                              algorithm='Dummy'))
 
     def test_analyse(self):
         """ Using a plugin """
@@ -142,6 +136,7 @@ class ExtensionsTest(TestCase):
     def test_analyse_error(self):
         mm = mock.MagicMock()
         mm.id = 'magic_mock'
+        mm.is_activated = True
         mm.analyse_entries.side_effect = Error('error in analysis', status=500)
         self.senpy.plugins['MOCK'] = mm
         try:

tests/test_plugins.py

@@ -214,20 +214,22 @@ class PluginsTest(TestCase):
         assert res["onyx:hasEmotionCategory"] == "c2"
 
 
-def make_mini_test(plugin):
+def make_mini_test(plugin_info):
     def mini_test(self):
+        plugin = plugins.load_plugin_from_info(plugin_info, install=True)
         plugin.test()
     return mini_test
 
 
-def add_tests():
+def _add_tests():
     root = os.path.dirname(__file__)
-    plugs = plugins.load_plugins(os.path.join(root, ".."))
+    plugs = plugins.load_plugins(os.path.join(root, ".."), loader=plugins.parse_plugin_info)
     for k, v in plugs.items():
+        pass
         t_method = make_mini_test(v)
         t_method.__name__ = 'test_plugin_{}'.format(k)
         setattr(PluginsTest, t_method.__name__, t_method)
         del t_method
 
 
-add_tests()
+_add_tests()