PEP8 compliance

senpy/blueprints.py

@@ -1,27 +1,28 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
-#    Copyright 2014 J. Fernando Sánchez Rada - Grupo de Sistemas Inteligentes
-#                                                       DIT, UPM
+# Copyright 2014 J. Fernando Sánchez Rada - Grupo de Sistemas Inteligentes
+# DIT, UPM
 #
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
 #
-#        http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0
 #
-#    Unless required by applicable law or agreed to in writing, software
+# Unless required by applicable law or agreed to in writing, software
 #    distributed under the License is distributed on an "AS IS" BASIS,
 #    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #    See the License for the specific language governing permissions and
 #    limitations under the License.
-'''
-Simple Sentiment Analysis server
-'''
+"""
+Blueprints for Senpy
+"""
 import json
 import logging
+
 logger = logging.getLogger(__name__)
 
-from flask import Blueprint, render_template, request, jsonify, current_app
+from flask import Blueprint, request, jsonify, current_app
 
 nif_blueprint = Blueprint("NIF Sentiment Analysis Server", __name__)
 
@@ -31,8 +32,8 @@ BASIC_PARAMS = {
                   },
 }
 
+
 def get_params(req, params=BASIC_PARAMS):
-    indict = None
     if req.method == 'POST':
         indict = req.form
     elif req.method == 'GET':
@@ -41,37 +42,37 @@ def get_params(req, params=BASIC_PARAMS):
         raise ValueError("Invalid data")
 
     outdict = {}
-    wrongParams = {}
+    wrong_params = {}
     for param, options in params.iteritems():
         for alias in options["aliases"]:
             if alias in indict:
                 outdict[param] = indict[alias]
         if param not in outdict:
             if options.get("required", False):
-                wrongParams[param] = params[param]
+                wrong_params[param] = params[param]
             else:
                 if "default" in options:
                     outdict[param] = options["default"]
         else:
-            if "options" in params[param] and \
-                outdict[param] not in params[param]["options"]:
-                wrongParams[param] = params[param]
-    if wrongParams:
-        message = {"status": "failed", "message": "Missing or invalid parameters"}
-        message["parameters"] = outdict
-        message["errors"] = {param:error for param, error in wrongParams.iteritems()}
+            if "options" in params[param] and outdict[param] not in params[param]["options"]:
+                wrong_params[param] = params[param]
+    if wrong_params:
+        message = {"status": "failed",
+                   "message": "Missing or invalid parameters",
+                   "parameters": outdict,
+                   "errors": {param: error for param, error in wrong_params.iteritems()}
+                   }
         raise ValueError(json.dumps(message))
     return outdict
 
+
 def basic_analysis(params):
     response = {"@context": ["http://demos.gsi.dit.upm.es/eurosentiment/static/context.jsonld",
                              {
                                  "@base": "{}#".format(request.url.encode('utf-8'))
                              }
                              ],
-                "analysis": [{
-                    "@type": "marl:SentimentAnalysis"
-                }],
+                "analysis": [{"@type": "marl:SentimentAnalysis"}],
                 "entries": []
                 }
     if "language" in params:
@@ -83,8 +84,9 @@ def basic_analysis(params):
         })
     return response
 
+
 @nif_blueprint.route('/', methods=['POST', 'GET'])
-def home(entries=None):
+def home():
     try:
         algo = get_params(request).get("algorithm", None)
         specific_params = current_app.senpy.parameters(algo)
@@ -96,11 +98,13 @@ def home(entries=None):
     except Exception as ex:
         return jsonify(status="400", message=ex.message)
 
+
 @nif_blueprint.route("/default")
 def default():
     return current_app.senpy.default_plugin
     #return plugins(action="list", plugin=current_app.senpy.default_algorithm)
 
+
 @nif_blueprint.route('/plugins/', methods=['POST', 'GET'])
 @nif_blueprint.route('/plugins/<plugin>', methods=['POST', 'GET'])
 @nif_blueprint.route('/plugins/<plugin>/<action>', methods=['POST', 'GET'])
@@ -113,7 +117,7 @@ def plugins(plugin=None, action="list"):
         return "Plugin not found", 400
     if action == "list":
         with_params = request.args.get("params", "") == "1"
-        dic = {plug:plugs[plug].jsonable(with_params) for plug in plugs}
+        dic = {plug: plugs[plug].jsonable(with_params) for plug in plugs}
         return jsonify(dic)
     if action == "disable":
         current_app.senpy.disable_plugin(plugin)
@@ -127,9 +131,11 @@ def plugins(plugin=None, action="list"):
     else:
         return "action '{}' not allowed".format(action), 400
 
+
 if __name__ == '__main__':
     import config
     from flask import Flask
+
     app = Flask(__name__)
     app.register_blueprint(nif_blueprint)
     app.debug = config.DEBUG